Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): [#127] Bump Netbeans Platform from 20 to 21 #138

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore(deps): [#127] Bump Netbeans Platform from 20 to 21 #138

wants to merge 8 commits into from

Conversation

ursjoss
Copy link
Collaborator

@ursjoss ursjoss commented Mar 26, 2024 •
edited by RadekCap

Fixes #137

@ursjoss ursjoss marked this pull request as ready for review March 26, 2024 12:44
@ursjoss ursjoss requested a review from RadekCap March 26, 2024 17:02
@RadekCap
Copy link
Collaborator

RadekCap commented Mar 26, 2024 •
edited

List what to check:

  • local compilation and run on Linux
  • local compilation and run on Mac
  • run on Mac OS
  • run on Windows
  • tools menu is missing
  • the build passes on github actions (green build)
  • I can run the application from Netbeans
  • I can build the installer, install the linux one and run the installed app w/o any warning at startup.
  • I can build the installer, install the mac one and run the installed app w/o any warning at startup.

List of issues which should be fixed here as well

None of runs should contains any complains about modules.

@ursjoss
Copy link
Collaborator Author

ursjoss commented Apr 5, 2024 •
edited

I documented the menu structure of TR 3.7.0 in the wiki.

Currently missing (compared to 3.7.0) when checking menu:

  • Menu File
    • Exit
  • Menu Edit
    • Cut
    • Copy
    • Paste
    • Delete
  • Menu View (missing entirely)
  • Menu Tools
    • Plugins
    • Options: Tabs
      • General
      • Keymap
      • Miscellaneous -> Output
  • Menu Help
    • Help Contents
    • Shortcuts
      • Move Down
      • Move Up
    • Check for Updates
    • About

@ursjoss ursjoss marked this pull request as draft April 5, 2024 09:43
@ursjoss ursjoss assigned ursjoss and unassigned RadekCap Apr 5, 2024
@ursjoss
Re-include Apple Application Menu
a3d5e62 
Not sure on it's effect - to be on the safe side
@ursjoss
Re-introduce Platform dependency 'Core - UI'
0568b76 
Resolves:
- Menu File -> Missing Exit
- Menu Edit -> Missing Cut, Copy, Paste, and Delete
- Menu Help -> Missing Shortcuts (up, down), Info
- Menu Tools -> Options -> Tabs General
@ursjoss
Re-introduce Platform dependency 'Keymap Options'
76a5200 
Restoring from Menu Tools -> options Dialog. Keymap Options
@ursjoss
Re-introduce Platform dependency 'Autoupdate UI'
93b7eb1 
Restores from Menu Tools -> Plugins Dialog and
from Menu Help -> Check for updates
@ursjoss
Re-introduce Platform dependency 'Output Window'
e64010d 
Restores from Menu Tools -> Options -> Miscellaneous -> Tab Output
@ursjoss
Copy link
Collaborator Author

ursjoss commented Apr 5, 2024 •
edited

Out of the missing menu entries reported above, all are resolved with the recent commits, except for the missing Menu "View". As this has been missing in recent versions of 4.0.0-BETA already, I suggest to handle its re-introduction in the context of a separate Ticket -> #141.

@ursjoss ursjoss mentioned this pull request Apr 5, 2024
Open
@ursjoss ursjoss marked this pull request as ready for review April 6, 2024 13:48
@ursjoss ursjoss assigned RadekCap and unassigned ursjoss Apr 6, 2024
@ursjoss ursjoss mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadekCap RadekCap Awaiting requested review from RadekCap

At least 1 approving review is required to merge this pull request.

Assignees

@RadekCap RadekCap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Netbeans to 21
2 participants
@ursjoss @RadekCap