Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unwanted modules by default #64

Closed
RadekCap opened this issue Jan 16, 2023 · 8 comments
Closed

Disable unwanted modules by default #64

RadekCap opened this issue Jan 16, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@RadekCap
Copy link
Collaborator

By #61 we probably introduced loading of some modules. When you run application from the latest source code, the message box appear with warning:

Warning - could not install some modules: JSch Agent Proxy library - The module named com.jcraft.jsch was needed and not found.
HTML Validation - The module named org.apache.commons.logging was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.mylyn.commons.net was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.mylyn.tasks.core was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.core.jobs was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.mylyn.wikitext.core was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.equinox.common was needed and not found.
Mylyn Support Utilities - The module named org.eclipse.core.runtime was needed and not found.
Local Tasks - The module named org.eclipse.mylyn.tasks.core was needed and not found.
Local Tasks - The module named org.eclipse.equinox.common was needed and not found.
Local Tasks - The module named org.eclipse.core.runtime was needed and not found.
Bugzilla - The module named org.eclipse.mylyn.commons.net was needed and not found.
Bugzilla - The module named org.eclipse.mylyn.bugzilla.core was needed and not found.
Bugzilla - The module named org.eclipse.mylyn.tasks.core was needed and not found.
Bugzilla - The module named org.eclipse.equinox.common was needed and not found.
Bugzilla - The module named org.apache.commons.httpclient was needed and not found.
Bugzilla - The module named org.eclipse.core.runtime was needed and not found.
Native Execution - The module named com.jcraft.jsch was needed and not found.
TextMate Lexer - The module named com.google.gson was needed and not found.
LSP Client - The module named com.google.guava was needed and not found.
LSP Client - The module named com.google.gson was needed and not found.
Git Client Library - The module named org.eclipse.jgit was needed and not found.
Git Client Library - The module named com.jcraft.jsch was needed and not found.
Git - The module named org.eclipse.jgit was needed and not found.
10 further modules could not be installed due to the above problems.

It appears just only one, it's skippable and never occurs again. I'm not sure if this is worth to solve but a new collaborators could be a little bit scared but his huge warning :)

Screenshot from 2023-01-16 10-54-42

@ursjoss
Copy link
Collaborator

ursjoss commented Jan 16, 2023

Could probably be solved in context of ticket #57. could we treat this ticket as duplicate and you paste your findings there?

@RadekCap RadekCap added the bug Something isn't working label Jan 16, 2023
@RadekCap
Copy link
Collaborator Author

It probably could be solved there but this is something that could discourage contributors so I've marked it as a bug so it'll will have a little higher priority.

@RadekCap
Copy link
Collaborator Author

During the first start after clean compilation, and after modules warning, another dialog appears. This one:

Image 16 01 2023 at 19 56

We should probably hide it as well. Or, maybe better, understand how it's working and use it the next time during the new release.

@ursjoss
Copy link
Collaborator

ursjoss commented Jan 16, 2023

:-) This pop-up is the result from fixing the issue of #60. With the fix from PR #61, the messages from the endpoint are downloaded correctly by the MessageChecker and passed on to the MessageParser. The last check-date is cached, but since you have a clean repo (as you describe it after cleaning it), the code considers the check to be the first one. In this case, all valid messages are displayed. Currnelty, there is exactly one message not commented out. It is therefore displayed once (unless you clean again).

See the message here:

It is true, that we should not show that outdated message once we release a version 4.0.0. Until then, I don't mind. To not show the version, @clairelema should remove it from the XML.

@ursjoss
Copy link
Collaborator

ursjoss commented Jan 17, 2023

I found a link to an article stating that those symptoms may be caused by an outdated netbeans cache. Deleting the cached files may resolve it.

After having deleted my netbeans cache (on my linux system ~/.cache/netbeans/16/), I have not had the issue anymore. Let's see if it pops up in the near future.

@RadekCap
Copy link
Collaborator Author

Unfortunately, it's still present on my RHEL system after cache deletion.

@ursjoss
Copy link
Collaborator

ursjoss commented Mar 6, 2023

@RadekCap We might be able to close it now, what do you think?

@RadekCap
Copy link
Collaborator Author

RadekCap commented Mar 6, 2023

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants