Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add COMPUTERNAME to WIndows Folder Tokens #20

Closed
tmnc opened this issue Jul 30, 2018 · 1 comment · Fixed by #31
Closed

Add COMPUTERNAME to WIndows Folder Tokens #20

tmnc opened this issue Jul 30, 2018 · 1 comment · Fixed by #31

Comments

@tmnc
Copy link

tmnc commented Jul 30, 2018

You already have username and domain, why not add COMPUTERNAME to the information collected when someone visits a WIndows Folder Token?
@thinkst
Copy link
Collaborator

thinkst commented Aug 16, 2018

Hey @tmnc,

That sounds like a good idea. Do you have any advice on how we can make this happen? (also we encourage you to collaborate with pull requests - this would be a cool addition!)

@bromiley bromiley mentioned this issue Dec 18, 2018
Merged
thinkst pushed a commit that referenced this issue Jan 7, 2019
@bromiley
Hostname added to Folder Access canary (#31)
1d4db9c 
* Added hostname capture in folder access canary

* Fixed multi-line formatting issue; resolves #20

* Updated PR with suggested changes. Thanks!

* Updated gitignore to include VS Code

* Updated regex to treat third group as optional if not found for backwards compatibility

* Updated ziplib.py

Fixed USERDOMAIN typo :)
wleightond added a commit that referenced this issue May 5, 2023
@wleightond
AWS key token integration test (#20)
ef73c05 
* added aws key token integration test

* added wait for creds to be recognised and capped all wait times

* fix a new error in a unit test, add an example hit for aws key token

Co-authored-by: William Leighton Dawson <leighton@thinkst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hostname added to Folder Access canary bromiley/canarytokens
1 participant
@tmnc