Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomPassword: Fix variable declaration to adhere to best practices #986

Merged

Conversation

ZikaZaki
Copy link
Contributor

Description

This pull request addresses a coding style and best practice issue related to variable declaration in the randomPassword project codebase, specifically in the bhatshakran\utils.js file. The usage of the let keyword for declaring the capitals variable is inconsistent with best practices, and it can be replaced with the const keyword to improve code readability and maintainability.

Changes Made

  • Replaced the usage of let with const when declaring the capitals variable in the provided code snippet.
  • Ensured that the capitals array, being declared as const, so it cannot be accidentally reassigned.

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure.
  • Starred ⭐ the Repo (Optional)

@NitkarshChourasia NitkarshChourasia merged commit 5fa4772 into thinkswell:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants