Fix onConnect called twice with inApp social login in ConnectButton (#…

…3085)
thirdweb-dev · May 20, 2024 · a22eb5c · a22eb5c
1 parent c494af8
commit a22eb5c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/blue-lemons-destroy.md b/.changeset/blue-lemons-destroy.md
@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix `onConnect` prop called twice when connecting inApp wallet using Social login
diff --git a/packages/thirdweb/src/react/web/wallets/in-app/InAppWalletFormUI.tsx b/packages/thirdweb/src/react/web/wallets/in-app/InAppWalletFormUI.tsx
@@ -55,7 +55,7 @@ export type InAppWalletFormUIProps = {
 export const InAppWalletFormUI = (props: InAppWalletFormUIProps) => {
   const locale = props.locale;
   const { chain, client, connectModal } = useConnectUI();
-  const { done, wallet } = props;
+  const { wallet } = props;
   const setData = useSetSelectionData() as (
     value: InAppWalletSelectUIState,
   ) => void;
@@ -134,10 +134,11 @@ export const InAppWalletFormUI = (props: InAppWalletFormUIProps) => {
           connectionPromise: connectPromise,
         },
       });
-      props.select();
 
-      await connectPromise;
-      done();
+      props.select(); // show Connect UI
+
+      // Note: do not call done() here, it will be called InAppWalletSocialLogin component
+      // we simply trigger the connect and save promise here - its resolution is handled in InAppWalletSocialLogin
     } catch (e) {
       console.error(`Error sign in with ${strategy}`, e);
     }