Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing Fixes, Revert color changes #3107

Merged
merged 4 commits into from
May 22, 2024
Merged

Spacing Fixes, Revert color changes #3107

merged 4 commits into from
May 22, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 21, 2024

PR-Codex overview

This PR fixes spacing and color issues in UI components across thirdweb.

Detailed summary

  • Fixed spacing and color inconsistencies in UI components
  • Reverted color changes in UI components
  • Updated image handling in various components
  • Adjusted color schemes in the design system

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 10:48pm

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: e27a497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
playground-web Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #3107 will not alter performance

Comparing mnn/spacing-tweaks (e27a497) with main (e6fc042)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.21 KB (0%) 785 ms (0%) 3.1 s (+47.11% 🔺) 3.9 s
thirdweb (cjs) 88.59 KB (0%) 1.8 s (0%) 5.3 s (-19.96% 🔽) 7 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 461 ms (+92.84% 🔺) 556 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 45 ms (+1.65% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 15.63 KB (0%) 313 ms (0%) 372 ms (-34.9% 🔽) 685 ms

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 62.36%. Comparing base (c3b8cc7) to head (e27a497).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3107      +/-   ##
==========================================
+ Coverage   62.34%   62.36%   +0.01%     
==========================================
  Files         802      802              
  Lines       59944    59930      -14     
  Branches     3220     3220              
==========================================
- Hits        37374    37373       -1     
+ Misses      21901    21888      -13     
  Partials      669      669              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from c3b8cc7
packages 61.63% <58.33%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...s/thirdweb/src/react/web/ui/design-system/index.ts 90.87% <100.00%> (ø)
...thirdweb/src/react/web/ui/components/TokenIcon.tsx 39.58% <0.00%> (ø)
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 16.66% <0.00%> (+0.10%) ⬆️
...kages/thirdweb/src/react/web/ui/components/Img.tsx 22.91% <0.00%> (+1.21%) ⬆️

@MananTank MananTank added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@joaquim-verges joaquim-verges merged commit 57f7cd5 into main May 22, 2024
16 of 17 checks passed
@joaquim-verges joaquim-verges deleted the mnn/spacing-tweaks branch May 22, 2024 03:16
@jnsdls jnsdls mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants