-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thirdweb): adds redirect oauth #3822
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3848327 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @gregfromstl and the rest of your teammates on Graphite |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3822 will not alter performanceComparing Summary
|
size-limit report 📦
|
2713c86
to
37de48d
Compare
37de48d
to
3dccd1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3822 +/- ##
==========================================
- Coverage 62.32% 61.99% -0.34%
==========================================
Files 963 967 +4
Lines 74813 75366 +553
Branches 3772 3775 +3
==========================================
+ Hits 46630 46720 +90
- Misses 27498 27961 +463
Partials 685 685
*This pull request uses carry forward flags. Click here to find out more.
|
3dccd1d
to
26c61cb
Compare
26c61cb
to
c20db52
Compare
Merge activity
|
### TL;DR Added support for OAuth redirects in the In-App wallet authentication flow. ### What changed? 1. Introduced `auth.mode` with options ` --- <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the ability to open OAuth windows as a redirect, beneficial for embedded applications like Telegram web apps. ### Detailed summary - Added `mode: "redirect"` option for OAuth windows - Implemented functions for OAuth redirection - Updated authentication options for in-app wallets > The following files were skipped due to too many changes: `packages/thirdweb/src/react/core/hooks/wallets/useAutoConnect.ts`, `packages/thirdweb/src/wallets/in-app/web/lib/web-connector.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
c20db52
to
3848327
Compare
TL;DR
Added support for OAuth redirects in the In-App wallet authentication flow.
What changed?
auth.mode
with options `PR-Codex overview
This PR adds the ability to open OAuth windows as a redirect, useful for embedded applications. It includes changes in redirect mode, OAuth handling, and social login.
Detailed summary
mode: "redirect"
option for OAuth windowsloginWithOauthRedirect
function for social login