ImageType::getFormatedName #1269
Labels
Comments
getdatakick
added a commit
that referenced
this issue
Oct 20, 2021
Method ImageType::getFormatedName() had problems with resolving names
for some legacy image types. For example, if image type was named
'panda_cart_default', then ImageType::getFormatedName('cart') returned
'cart' instead of 'panda_cart_default'.
The new algorithm is more permissive. But it is also more expensive.
However, the caching mechanism should offset the higher performance
requirements, as core/theme usually calls this method many times with
the same parameters.
Closes #1269
getdatakick
added a commit
that referenced
this issue
Oct 25, 2021
Method ImageType::getFormatedName() had problems with resolving names
for some legacy image types. For example, if image type was named
'panda_cart_default', then ImageType::getFormatedName('cart') returned
'cart' instead of 'panda_cart_default'.
The new algorithm is more permissive. But it is also more expensive.
However, the caching mechanism should offset the higher performance
requirements, as core/theme usually calls this method many times with
the same parameters.
Closes #1269
eschiendorfer
pushed a commit
to eschiendorfer/thirtybees
that referenced
this issue
Mar 23, 2022
Method ImageType::getFormatedName() had problems with resolving names
for some legacy image types. For example, if image type was named
'panda_cart_default', then ImageType::getFormatedName('cart') returned
'cart' instead of 'panda_cart_default'.
The new algorithm is more permissive. But it is also more expensive.
However, the caching mechanism should offset the higher performance
requirements, as core/theme usually calls this method many times with
the same parameters.
Closes thirtybees#1269
eschiendorfer
pushed a commit
to eschiendorfer/thirtybees
that referenced
this issue
May 22, 2022
Method ImageType::getFormatedName() had problems with resolving names
for some legacy image types. For example, if image type was named
'panda_cart_default', then ImageType::getFormatedName('cart') returned
'cart' instead of 'panda_cart_default'.
The new algorithm is more permissive. But it is also more expensive.
However, the caching mechanism should offset the higher performance
requirements, as core/theme usually calls this method many times with
the same parameters.
Closes thirtybees#1269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Analyzing the W3c validator evaluation of my site I noticed reports about 'width=""'.
Looking where this came from I saw that Panda's blockcart_mod module contains the line
'cartSize' => Image::getSize(ImageType::getFormatedName('cart'))
So I had a look at ImageType::getFormatedName and noticed that it didn't find anything and returned the search term instead of the desired 'panda_cart_default'.
When I looked at the code it seems completely wrong. The input variable $name is the basic "cart" and yet it is trying to remove the theme name from it in the first line. Later in the module this misunderstanding continues.
The text was updated successfully, but these errors were encountered: