Implemented Send Message tab #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hey, this is cool. Thanks for implementing this! Sorry, I've been out of pocket for the last few days. Don't worry about the failing CI, it's busted on master and fixed in a branch I've been working on off and on. |
thirtythreeforty
requested changes
Nov 25, 2018
|
GitHub Wiki pages may help explain software more without crowding the readme |
thirtythreeforty
approved these changes
Nov 27, 2018
|
Great, thanks! I'm going to clean up whitespace (the rule is actually "tabs for indent, spaces for alignment" and I didn't expect your editor to change all the lines in the file, but nbd) and maybe tweak wording, and it should be ready to roll. |
|
Woohoo! And I'm sorry about changing all the indentations! I'm used to JetBrains' IDE style, so I didn't realize that Qt Creator changed every line, lol. |
This comment has been minimized.
This comment has been minimized.
Techzune
pushed a commit
to Techzune/bullycpp
that referenced
this pull request
Nov 27, 2018
Implement Send Message tab (thirtythreeforty#27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an alternative way for the user to send messages (with backspace!) via serial. Instead of sending individual characters via console, this tab will send the entire message at once.
The send automatically will append a newline (\n) character to the message, but that can be overridden by holding down CTRL and sending.