Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace makefile with npm scripts #133

Closed
thisandagain opened this issue Feb 8, 2018 · 0 comments
Closed

Replace makefile with npm scripts #133

thisandagain opened this issue Feb 8, 2018 · 0 comments
Labels
bug help wanted

Comments

@thisandagain
Copy link
Owner

thisandagain commented Feb 8, 2018 •
edited

When I first built this thing I was using Makefiles for everything. While they work well for me, they cause a lot of problems for folks on Windows and other platforms where GNU Make is not available.
kevinchappell added a commit to kevinchappell/sentiment that referenced this issue Feb 11, 2018
@kevinchappell
improve(development): makefile rules to npm-scripts
28afff4 
Added: makefile rules to npm scripts
Added: prepush script that runs lint, test, benchmark, and validate
Removed: Makefile

Resolves thisandagain#133
@kevinchappell kevinchappell mentioned this issue Feb 11, 2018
Merged
kevinchappell added a commit to kevinchappell/sentiment that referenced this issue Feb 12, 2018
@kevinchappell
improve(development): makefile rules to npm-scripts
0a41a00 
Added: makefile rules to npm scripts
Added: prepush script that runs lint, test, benchmark, and validate
Removed: Makefile

Resolves thisandagain#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisandagain