improve(development): makefile rules to npm-scripts #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May need to update CI config: vercel/next.js#2303 Edit: turned out to be this npm/npm#17444 (comment) |
Added: makefile rules to npm scripts Added: prepush script that runs lint, test, benchmark, and validate Removed: Makefile Resolves thisandagain#133
kevinchappell
force-pushed
the
improvement/npm-scripts
branch
from
4ce63cd
to
0a41a00
Compare
|
@kevinchappell This looks great! Thank you! 😄 |
thisandagain
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: makefile rules to npm scripts
Added: prepush script that runs lint, test, benchmark, and validate
Removed: Makefile
Resolves #133