Skip to content

Commit

Permalink
do not require --minify with --minify-safe-only
Browse files Browse the repository at this point in the history
  • Loading branch information
thisismypassport committed Jun 21, 2023
1 parent 84080e9 commit a24a375
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion run_bbs_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def process_output(kind, output):
best_path_for_pico8 = compress_path

if g_opts.all or g_opts.only_safe_minify:
safe_minify_results = run_code(uncompress_path, safe_minify_path, "--minify", "--minify-safe-only", "--count", "--parsable-count")
safe_minify_results = run_code(uncompress_path, safe_minify_path, "--minify-safe-only", "--count", "--parsable-count")
process_output("safe_minify", check_run("%s:safe_minify" % cart, safe_minify_results, parse_meta=True))
best_path_for_pico8 = safe_minify_path

Expand Down
3 changes: 1 addition & 2 deletions run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ def run():
"--no-minify-spaces", "--no-minify-lines", pico8_output="output.p8.printh")
run_test("minrename", "input.p8", "output_minrename.p8", "--minify",
"--preserve", "*,*.*", pico8_output="output.p8.printh")
run_test("auto_minrename", "input.p8", "output_minrename.p8", "--minify",
"--minify-safe-only")
run_test("auto_minrename", "input.p8", "output_minrename.p8", "--minify-safe-only")
run_test("minifytokens", "input.p8", "output_tokens.p8", "--minify",
"--no-minify-spaces", "--no-minify-lines", "--no-minify-comments", "--no-minify-rename")
# pico8_output="output.p8.printh" - broken by comment bug in pico8 v0.2.5g...
Expand Down
2 changes: 1 addition & 1 deletion shrinko8.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def main(raw_args):
"undefined": not args.no_lint_undefined,
}

if args.minify:
if args.minify or args.minify_safe_only:
args.minify = {
"lines": not args.no_minify_lines,
"wspace": not args.no_minify_spaces,
Expand Down

0 comments on commit a24a375

Please sign in to comment.