Allow comments to contain absolute paths.

[jamestalmage]

Using path.resolve instead of path.join allows for absolute paths on Windows. The Node.js documentation does not provide a clear reason why, but I have verified this solves my issue.

You can prove this to yourself with the following command:

$ node -e "console.log(path.win32.join('C:\\foo\\bar', 'D:\\baz\\quz.js'));"
$ node -e "console.log(path.win32.resolve('C:\\foo\\bar', 'D:\\baz\\quz.js'));"

[rundef]

This is an issue for me as well ; the typescript ts-node transpiler generates source maps links such as:

//# sourceMappingURL=/tmp/ts-node/72c27f/751238.js.map

But, when using the nyc code coverage tool, nyc calls the fromMapFileSource function from convert-source-map, and it fails at line 30 in the readFromFileMap function, because of the absolute path not being handled correctly.

My solution was to replace this line (in the readFromFileMap function) :

var filepath = path.join(dir, filename);

by

var filepath = path.isAbsolute(filename) ? filename : path.join(dir, filename);

But the code in this PR works as well.

Is it possible to get this merged @thlorenz ?

Thank you

[thlorenz]

LGTM and if all tests pass we can merge.
However we'd need to publish as a minor upgrade as it'd change behavior in cases when the dir is provided as a relative path as well.

[thlorenz]

@jamestalmage made you collaborator.

Please merge to master following this guide.
I will then version and publish to npm.

Thanks.

[jamestalmage]

Merged.

FYI: The merge guide seems a bit outdated. Using the "Squash and Merge" option from the GH UI works the same as a fast forward merge. You should be able to adjust the default and/or disable merge commits in the settings for the repo.

[thlorenz]

Thanks, published as v1.3.0.
Good point WRT the merge guide I'll update when I get some time.