Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments to contain absolute paths. #41

Merged

Commits on May 7, 2016

  1. Allow comments to contain absolute paths.

    Using `path.resolve` instead of `path.join` allows for absolute paths on Windows. The Node.js documentation does not provide a clear reason why, but I have verified this solves my issue.
    
    You can prove this to yourself with the following command:
    
    ```
    $ node -e "console.log(path.win32.join('C:\\foo\\bar', 'D:\\baz\\quz.js'));"
    $ node -e "console.log(path.win32.resolve('C:\\foo\\bar', 'D:\\baz\\quz.js'));"
    ```
    jamestalmage committed May 7, 2016
    Configuration menu
    Copy the full SHA
    990333f View commit details
    Browse the repository at this point in the history