Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and github workflow for parsing logs #17

Merged
merged 8 commits into from
Sep 18, 2020

Conversation

andrewiggins
Copy link
Collaborator

Add tests for parsing logs and a github workflow that runs the tests on push.

I checked in the logs of running the examples in the repo on my local machine. However, the paths in the logs are absolute paths to the location of the files on my machine (/tmp/deoptigate). So the tests replace the paths of the source files with the local path to the source files before running the logs through deoptigate.

@thlorenz
Copy link
Owner

thlorenz commented Jul 4, 2020

Wow super nice .. this repo was in dire need of tests. Which would also make it possible to refactor to something a bit more maintainable, maybe even typescript.
So thanks a lot!

Also looks like you didn't touch any of the lib code .. so I got no objection to merging this. Probably wanna squash it though.

So I made you collaborator.

Please merge to master following this guide.
I will then version and publish to npm.

Thanks.

@andrewiggins
Copy link
Collaborator Author

Now that GitHub has a squash merge button, would it be okay to use that button to perform the squash merge? (Asking cuz your collaborator guide suggests please do not use the green button on github).

@andrewiggins
Copy link
Collaborator Author

Going to go ahead an squash merge this. Obviously let me know if anything looks wrong so I can fix it!

@andrewiggins andrewiggins merged commit 632a075 into thlorenz:master Sep 18, 2020
@andrewiggins andrewiggins deleted the tests branch September 18, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants