Refactored subgraphstack and eulertrail related .h and .cpp files #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeintrup
force-pushed
the
refactoring
branch
from
50b8599
to
c727488
Compare
shsr04
requested changes
Dec 4, 2018
There was a problem hiding this comment.
There should not be additional subdirectories in the include folder. We only want these four:
- collection
- dictionary
- graph
- iterator
Please try to fit all your classes in one of these categories (and remove include/eulertrail and include/rankselect). Inside the src directory, we can create many subdirectories for our convenience.
| #include <sealib/localdycktable.h> | ||
| #include <sealib/dyckmatchingstructure.h> | ||
| #include <sealib/dictionary/rankselect.h> | ||
| #include "../../../src/eulertrail/localdycktable.h" |
There was a problem hiding this comment.
You can't reference the src folder from a public header file. Either make this file private or the other one public.
| #ifndef SEALIB_BYTECOUNTER_H_ | ||
| #define SEALIB_BYTECOUNTER_H_ | ||
| #ifndef SEALIB_MEASUREMENT_BYTECOUNTER_H_ | ||
| #define SEALIB_MEASUREMENT_BYTECOUNTER_H_ |
There was a problem hiding this comment.
The ByteCounter does not fit into any of our 4 categories, so it can be put directly in the include/ folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.