Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace subgroup by sub #576

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Replace subgroup by sub #576

merged 1 commit into from
Feb 2, 2022

Conversation

fingolfin
Copy link
Contributor

@fingolfin fingolfin commented Feb 2, 2022

Completely untested, but subgroup does not seem to be defined anywhere? Perhaps I missed something, or perhaps these functions are simply not covered by CI?

Motivated by https://github.com/oscar-system/Oscar.jl/issues/667

@thofma
Copy link
Owner

thofma commented Feb 2, 2022

I think I used it in some project a while ago. I am sure I added it for a reason, but unfortunately without tests it seems.

@fingolfin
Copy link
Contributor Author

I guess you renamed those in #396 and then perhaps due to some time overlap between PRs these additional uses crept in?

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #576 (bc7e33b) into master (2a2ecb7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   69.52%   69.51%   -0.02%     
==========================================
  Files         312      312              
  Lines       92059    92059              
==========================================
- Hits        64006    63994      -12     
- Misses      28053    28065      +12     
Impacted Files Coverage Δ
src/NumFieldOrd/NfOrd/Ideal/Prime.jl 79.42% <0.00%> (-0.62%) ⬇️
src/NumFieldOrd/NfOrd/Clgp.jl 76.33% <0.00%> (-4.92%) ⬇️
src/Map/NfRelOrd.jl 88.29% <0.00%> (-2.13%) ⬇️
src/NumFieldOrd/NfOrd/Ideal/TwoElement.jl 57.03% <0.00%> (-1.45%) ⬇️
src/LocalField/neq.jl 74.74% <0.00%> (-1.02%) ⬇️
src/NumField/NfAbs/CompactRepresentation.jl 82.16% <0.00%> (-0.96%) ⬇️
src/Misc/Series.jl 46.70% <0.00%> (-0.55%) ⬇️
src/NumFieldOrd/NfOrd/Clgp/Saturate.jl 64.76% <0.00%> (-0.55%) ⬇️
src/NumField/NfAbs/MPolyAbsFact.jl 70.72% <0.00%> (-0.54%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2ecb7...bc7e33b. Read the comment docs.

@thofma thofma merged commit 585606a into thofma:master Feb 2, 2022
@fingolfin fingolfin deleted the mh/sub branch February 2, 2022 14:40
FiroozehDastur referenced this pull request in FiroozehDastur/Hecke.jl Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants