Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failes with upcoming flake8 3.8.0 #66

Closed
fschulze opened this issue Apr 25, 2020 · 5 comments · Fixed by #68
Closed

failes with upcoming flake8 3.8.0 #66

fschulze opened this issue Apr 25, 2020 · 5 comments · Fixed by #68

Comments

@fschulze
Copy link

With the recently released flake8 3.8.0a2 the plugin fails:

lib/python2.7/site-packages/pytest_flake8.py:191: in check_file
    app.parse_preliminary_options_and_args(args)
AttributeError: 'Application' object has no attribute 'parse_preliminary_options_and_args'
@bobhy
Copy link

bobhy commented Apr 27, 2020

I have a V2 of this plugin which works (at least for me) with flake8 3.7 and 3.8. It's clonable from: https://github.com/bobhy/pytest-flake8, be sure to checkout branch use_flake8_config. Note, if you try this, it depends on flake8 config file almost exclusively.

@hoIIer
Copy link

hoIIer commented May 11, 2020

could we update the title to include the error? was just pulling my hair out trying to figure out why my ci/cd just started failing out of the blue with this error :)

@noviluni
Copy link

I just added a PR that fixed this: #68

@MartinThoma
Copy link

I just got this error with flake8-3.8.2 and pytest-flake8==1.0.4.

A work-around until this one is fixed seems to be to pin flake8==3.7.9

@FlorianHeigl
Copy link

FlorianHeigl commented Jun 18, 2020

@MartinThoma thank you so much, I got this while trying to fix a CI chain for an old project that I want to revive & port forward. I'm definitely not the right person to do that, but the one that does it. You saved me a lot of time now!

 onedns/zone.py                  53      0   100%
 ----------------------------------------------------------
 TOTAL                          334      0   100%
 ========================== 60 passed in 39.79 seconds ==========================
Running after_script
Saving cache
00:02
Uploading artifacts for successful job
00:01
 Job succeeded

YPCrumble added a commit to YPCrumble/python-statemachine that referenced this issue Oct 2, 2020
fgmacedo pushed a commit to fgmacedo/python-statemachine that referenced this issue Oct 21, 2020
* Pin TravisCI badge to the develop branch.
Fixes #248.

* Pin flake8 to version 3.7.9.
See tholo/pytest-flake8#66 (comment)
liZe added a commit to endlessm/azafea that referenced this issue Mar 25, 2021
Mainly required to fix pytest-flake8 behavior with recent versions of Flake8.

See tholo/pytest-flake8#66.
spenczar added a commit to spenczar/strimzi-registry-operator that referenced this issue Oct 26, 2021
pytest-flake8 uses private APIs of flake8. One of these APIs was removed in
flake8 3.8, which temporarily broke pytest-flake8. This was fixed in
pytest-flake8 v1.0.6.

References:

Github Issue describing the bug:
tholo/pytest-flake8#66

Fix: tholo/pytest-flake8#68

Release tag that includes fix:
https://github.com/tholo/pytest-flake8/releases/tag/1.0.6
zultron added a commit to zultron/hal_ros_control that referenced this issue May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants