fix compatibility with flake8 > 3.7 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noviluni
force-pushed
the
fix_new_flake8_version_compatibility
branch
from
d0c9aee
to
1da98fc
Compare
noviluni
force-pushed
the
fix_new_flake8_version_compatibility
branch
from
1da98fc
to
e2461d1
Compare
|
+1 |
This was referenced May 12, 2020
This was referenced May 12, 2020
Gallaecio
approved these changes
May 12, 2020
asottile
reviewed
May 12, 2020
cottsay
added a commit
to ros-infrastructure/ros_buildfarm
that referenced
this pull request
May 26, 2020
Modeled after tholo/pytest-flake8#68. Also resolve flake8 violations after latest flake8 release.
spenczar
added a commit
to spenczar/strimzi-registry-operator
that referenced
this pull request
Oct 26, 2021
pytest-flake8 uses private APIs of flake8. One of these APIs was removed in flake8 3.8, which temporarily broke pytest-flake8. This was fixed in pytest-flake8 v1.0.6. References: Github Issue describing the bug: tholo/pytest-flake8#66 Fix: tholo/pytest-flake8#68 Release tag that includes fix: https://github.com/tholo/pytest-flake8/releases/tag/1.0.6
|
And it broken again with flake6 :( |
|
@Et7f3 I ditched this package and just use flake8 directly now since it works with latest pytest versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8==3.8has been released and it deprecates some functions, causing this package to stop working as expected and generating a lot of errors.I fixed it to work with this new version.
It would be really nice to release this as soon as possible to avoid some pipelines to fail.
Let me know what you think @tholo 😄
Fixes #66