Add option for "External Pull To Clear."

[tateu]

This allows Priority Hub to post a notification that third party tweaks can monitor so they can perform their own Pull to Clear methods.

I am using this in the new alpha version of my tweak Perpetual 8, that I am currently working on. The original version, Perpetual, worked with Priority Hub's default Pull to Clear method but, because of some back end changes I made in Perpetual 8, it no longer works.

[thomasfinch]

I can definitely add this, I'm just curious if the preference switch is needed? It seems like just posting the NSDistributedNotificationCenter notification when pull to clear is activated would work fine, the user doesn't really need to know what's happening in the background. Would that be ok?

[tateu]

Priority Hub's behavior on Pull to Clear ([bulletinObserver clearSection:phContainerView.selectedAppID]) also clears notifications from the Notification Center, not just from the LockScreen. I, personally, don't want that to happen on my device so I created the Preference option that only sends the notification and lets me decide how it is handled.

I think everyone else will be fine with doing it the way you suggest because they won't notice any differences from how Priority Hub currently works...so it probably makes more sense, your way, and to not confuse users with a new, vaguely named Preference switch.

Since I am possibly the only person that wants it working that way, I am certainly fine with continuing to use my custom version while everyone else get's an official version implemented your way.

Thanks

[thomasfinch]

What about if priority hub checked if Perpetual 8 was installed when clearing, and posted the notification instead of doing the normal clear if it’s installed? It could maybe also check if Perpetual is enabled, and I’m sure you could integrate that pretty easily.

On Thu, Sep 3, 2015 at 7:58 PM, Josh Harris notifications@github.com
wrote:

Priority Hub's behavior on Pull to Clear ([bulletinObserver clearSection:phContainerView.selectedAppID]) also clears notifications from the Notification Center, not just from the LockScreen. I, personally, don't want that to happen on my device so I created the Preference option that only sends the notification and let's me decide how it is handled.
I think everyone else will be fine with doing it the way you suggest because they won't notice any differences from how Priority Hub currently works...so it probably makes more sense, your way, and to not confuse users with a new, vaguely named Preference switch.
Since I am possibly the only person that wants it working that way, I am certainly fine with continuing to use my custom version while everyone else get's an official version implemented your way.

Thanks

Reply to this email directly or view it on GitHub:
#20 (comment)

[tateu]

Sure, that sounds good. I'd then be able to add switches in Perpetual 8 to allow it to clear just the LS or also from the NC, if I so desired.

[tateu]

Any recent thoughts about this?

[thomasfinch]

Sorry I took so long to respond to this, I honestly kind of forgot about it. I was doing some cleanup and refactoring on priority hub today and am planning on pushing a beta soon, is this still needed? If so, how would you like me to add it?

[tateu]

It's no problem at all. We all have other things going on and, especially for something given away for free, we can't be expected to always be available.

And actually, I'd say hold off on it for now. I didn't even realize it, because I've been using my modified PH but, on iOS 9, it seems that PHs Pull to Clear works with Perpetual 9 for everything except iOS Mail notifications. A user pointed this out to me the other day. I disagreed, he insisted, so I tried it out and, what do you know, it worked.

I haven't had time to go through Perpetual 9s code since I found this out, so I'm not sure if I need to do something to rebreake it so it no longer works with PH again or just fix it so it also works with Mail notifications.

If you don't mind just doing nothing for now...I'll eventually get around to looking into it, and will update you then, if I think I still need changes.

Thanks.