Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Standard 2.0 #9

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Support .NET Standard 2.0 #9

merged 1 commit into from
Feb 6, 2022

Conversation

krdmllr
Copy link
Contributor

@krdmllr krdmllr commented Aug 16, 2019

Hi,

this PR brings all required changes to support .NET Standard 2.0

  • Use new SDK style project file
  • Target .netstandard2.0 besides .NET 4.6.1 for legacy support
  • Remove System.Drawing.Common since it depends on GDI which can lead to problems (for example in Azure Functions as I experienced :P ) -> Replaced with SixLabors.Fonts (Apache-2.0)
  • Remove nunit dll's and use NuGet package instead

Additionaly package information could get added to the new project file as a .nuspec file for packing and publishing the package is obsolete https://docs.microsoft.com/de-de/dotnet/core/tools/csproj#nuget-metadata-properties

@thomasjo thomasjo self-assigned this Jan 27, 2022
@thomasjo thomasjo merged commit eb6a546 into thomasjo:master Feb 6, 2022
@thomasjo
Copy link
Owner

thomasjo commented Feb 6, 2022

Thanks for your contribution @krdmllr 🥳 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants