Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasjohnkane committed Feb 10, 2020
1 parent 930c6f3 commit 8872396
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
- Handle errors silently (catch statement, logging)

# Steps
[X] Install orchestra testbench (Laravel Collective)
[X] Build tests
[] Benchmark performance impact (seed data with package, and without...laravel start time diff??)
[] Branding/marketing planning with Caleb
[] Update Readme
- [X] Install orchestra testbench (Laravel Collective)
- [X] Build tests
- [ ] Benchmark performance impact (seed data with package, and without...laravel start time diff??)
- [ ] Branding/marketing planning with Caleb
- [ ] Update Readme


1 change: 0 additions & 1 deletion src/SlowQueryNotifierProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public function register()
public function boot()
{
if (config('slow_query_notifier.enabled', true)) {
Log::info('Enabled...');
\DB::listen(function ($query) {
app(SlowQueryNotifier::class)->checkQuery($query);
});
Expand Down
2 changes: 1 addition & 1 deletion tests/SlowQueryNotifierTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function queries_slower_than_given_threshold_send_email()
Notification::fake();
SlowQueryNotifier::threshold(99)->toEmail('amdin@example.dev');

$result = \DB::connection('sqn')->select(\DB::raw('SELECT sleep(100)'));
$result = $connection->select(\DB::raw('SELECT sleep(100)'));
$notifiable = (new AnonymousNotifiable)->route('email', 'amdin@example.dev');

Notification::assertSentTo($notifiable, SlowQueryNotification::class);
Expand Down

0 comments on commit 8872396

Please sign in to comment.