Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix POSIX file_accessor for Mac OS. #105

Closed
Mortal opened this issue Aug 26, 2013 · 3 comments
Closed

Fix POSIX file_accessor for Mac OS. #105

Mortal opened this issue Aug 26, 2013 · 3 comments
Assignees
@Mortal
Labels
Reviewed

Comments

@Mortal
Copy link
Collaborator

Mortal commented Aug 26, 2013

See branch macos_fadvise, in which posix.inl is refactored and an #ifdef is added for Mac OS.
@ghost ghost assigned Mortal Aug 26, 2013
@Mortal Mortal mentioned this issue Aug 26, 2013
Closed
@jvahrenhold
Copy link
Collaborator

Works fine (there are some warnings about aggressive optimization and unused typedefs but they do not appear to be mac-related).

@Mortal
Copy link
Collaborator Author

Mortal commented Aug 27, 2013

OK, sounds good. @antialize let me know if you think we can merge this.

@antialize
Copy link
Collaborator

Merge merge.

@Mortal Mortal closed this as completed in 0b3639d Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mortal Mortal

Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antialize @jvahrenhold @Mortal