Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tpie compile on MacOS / gcc-4.8.1 #99

Closed
wants to merge 6 commits into from

Conversation

jvahrenhold
Copy link
Collaborator

No description provided.

@Mortal
Copy link
Collaborator

Mortal commented Aug 18, 2013

Thanks for the pull request - I'll have a look and merge it when I return to MADALGO in about a week.

@Mortal
Copy link
Collaborator

Mortal commented Aug 26, 2013

I think this is a bit too far-reaching, considering the proposed Mac OS file_accessor is almost identical to the POSIX file_accessor, and I'm not really able to maintain it.

I would prefer a more lightweight solution, using an #ifdef in posix.inl. @jvahrenhold please try out the branch macos_fadvise in thomasmoelhave/tpie, and comment on issue #105.

@jvahrenhold
Copy link
Collaborator Author

Done.

@Mortal Mortal closed this Aug 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants