Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiport support #1503

Merged
merged 4 commits into from Feb 2, 2024
Merged

Fix multiport support #1503

merged 4 commits into from Feb 2, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

When merging #1502 we had some errors in the the way the echo instances where managed.
This PR fixes the issue.

Changes include

  • Bugfix (non-breaking change that solves an issue)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

…ests

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 85510f2
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65bd151add6e2e0008743d80

thomaspoignant and others added 2 commits February 2, 2024 17:06
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c66b203) 87.67% compared to head (85510f2) 87.75%.

Files Patch % Lines
cmd/relayproxy/api/server.go 86.36% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
+ Coverage   87.67%   87.75%   +0.08%     
==========================================
  Files          77       77              
  Lines        3626     3627       +1     
==========================================
+ Hits         3179     3183       +4     
+ Misses        364      361       -3     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thomaspoignant thomaspoignant merged commit b29fe7f into main Feb 2, 2024
20 of 21 checks passed
@thomaspoignant thomaspoignant deleted the fix-multiple-port branch February 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant