Skip to content

Commit

Permalink
Extract methods to the base class
Browse files Browse the repository at this point in the history
  • Loading branch information
thombashi committed Aug 30, 2020
1 parent dbf1b6f commit f4438eb
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 20 deletions.
7 changes: 0 additions & 7 deletions pytablewriter/writer/binary/_excel.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ class ExcelTableWriter(AbstractBinaryTableWriter, metaclass=abc.ABCMeta):
def format_name(self) -> str:
return self.FORMAT_NAME

@property
def support_split_write(self) -> bool:
return True

@property
def workbook(self) -> Optional[ExcelWorkbookInterface]:
return self._workbook
Expand Down Expand Up @@ -221,9 +217,6 @@ def _write_table(self, **kwargs) -> None:
self._write_value_matrix()
self._postprocess()

def _write_value_row_separator(self) -> None:
pass

def _write_value_matrix(self) -> None:
for value_dp_list in self._table_value_dp_matrix:
for col_idx, value_dp in enumerate(value_dp_list):
Expand Down
13 changes: 13 additions & 0 deletions pytablewriter/writer/binary/_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,29 @@ def stream(self, value) -> None:
"cannot assign a stream to binary format writers. use open method instead."
)

@property
def support_split_write(self) -> bool:
return True

def __init__(self, **kwargs) -> None:
super().__init__(**kwargs)

self.table_name = kwargs.get("table_name", "")

self._stream = None

def __del__(self) -> None:
self.close()

def is_opened(self) -> bool:
return self.stream is not None

def dumps(self) -> str:
raise NotImplementedError("binary format writers did not support dumps method")

def _verify_stream(self) -> None:
if self.stream is None:
raise OSError("null output stream. required to open(file_path) first.")

def _write_value_row_separator(self) -> None:
pass
13 changes: 0 additions & 13 deletions pytablewriter/writer/binary/_sqlite.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ class SqliteTableWriter(AbstractBinaryTableWriter):
def format_name(self) -> str:
return self.FORMAT_NAME

@property
def support_split_write(self) -> bool:
return True

def __init__(self, **kwargs) -> None:
import copy

Expand All @@ -46,12 +42,6 @@ def __init__(self, **kwargs) -> None:

self._quoting_flags = copy.deepcopy(dataproperty.NOT_QUOTING_FLAGS)

def __del__(self) -> None:
self.close()

def is_opened(self) -> bool:
return self.stream is not None

def open(self, file_path: str) -> None:
"""
Open a SQLite database file.
Expand Down Expand Up @@ -109,6 +99,3 @@ def _write_table(self, **kwargs) -> None:
max_workers=self.max_workers,
)
self.stream.create_table_from_tabledata(table_data)

def _write_value_row_separator(self) -> None:
pass

0 comments on commit f4438eb

Please sign in to comment.