Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api changes in miflora break miflora-mqtt-daemon #156

Closed
derpeter opened this issue Jun 9, 2022 · 4 comments
Closed

Api changes in miflora break miflora-mqtt-daemon #156

derpeter opened this issue Jun 9, 2022 · 4 comments

Comments

@derpeter
Copy link

derpeter commented Jun 9, 2022

basnijholt/miflora#118 which made into the latest release requires to remove the retries flag from https://github.com/ThomDietrich/miflora-mqtt-daemon/blob/master/miflora-mqtt-daemon.py#L196

@ThomDietrich
Copy link
Owner

ThomDietrich commented Jun 21, 2022

Thanks for the report. Wish to create a PR?

@derpeter
Copy link
Author

I can create a PR if you prefer, as the change is very minimal i thought its less effort for you without it :-).
just let me know.

Btw thanks for the daemon very useful. Fun side node: I big bird stole one of my miflora sensors :-)

@ThomDietrich
Copy link
Owner

Fair point. I've just committed that change straight from the Github webpage :) I've also updated the requirement to https://github.com/basnijholt/miflora/releases/tag/v0.7.2

Can you confirm that everything works?

Fun side node
Hahahaa must have been a big one!

@derpeter
Copy link
Author

locks good to me, new version is up an running on my system. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants