Detect cookies on login page (elastic#120944)

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts
thomheymann · Dec 21, 2021 · f34947b · f34947b
1 parent 3ee6fa4
commit f34947b
Show file tree

Hide file tree

Showing 7 changed files with 293 additions and 7 deletions.
diff --git a/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap b/x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap
diff --git a/x-pack/plugins/security/public/authentication/login/login_app.test.ts b/x-pack/plugins/security/public/authentication/login/login_app.test.ts
@@ -18,7 +18,7 @@ describe('loginApp', () => {
 
     loginApp.create({
       ...coreSetupMock,
-      config: { loginAssistanceMessage: '' },
+      config: { loginAssistanceMessage: '', sameSiteCookies: undefined },
     });
 
     expect(coreSetupMock.http.anonymousPaths.register).toHaveBeenCalledTimes(1);
@@ -44,7 +44,7 @@ describe('loginApp', () => {
 
     loginApp.create({
       ...coreSetupMock,
-      config: { loginAssistanceMessage: 'some-message' },
+      config: { loginAssistanceMessage: 'some-message', sameSiteCookies: undefined },
     });
 
     const [[{ mount }]] = coreSetupMock.application.register.mock.calls;

diff --git a/x-pack/plugins/security/public/authentication/login/login_app.ts b/x-pack/plugins/security/public/authentication/login/login_app.ts
@@ -19,7 +19,7 @@ interface CreateDeps {
   application: ApplicationSetup;
   http: HttpSetup;
   getStartServices: StartServicesAccessor;
-  config: Pick<ConfigType, 'loginAssistanceMessage'>;
+  config: Pick<ConfigType, 'loginAssistanceMessage' | 'sameSiteCookies'>;
 }
 
 export const loginApp = Object.freeze({
@@ -41,6 +41,7 @@ export const loginApp = Object.freeze({
           notifications: coreStart.notifications,
           fatalErrors: coreStart.fatalErrors,
           loginAssistanceMessage: config.loginAssistanceMessage,
+          sameSiteCookies: config.sameSiteCookies,
         });
       },
     });

diff --git a/x-pack/plugins/security/public/authentication/login/login_page.test.tsx b/x-pack/plugins/security/public/authentication/login/login_page.test.tsx
@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import { EuiFlexItem } from '@elastic/eui';
 import { act } from '@testing-library/react';
 import { shallow } from 'enzyme';
 import React from 'react';
@@ -75,6 +76,20 @@ describe('LoginPage', () => {
   });
 
   describe('disabled form states', () => {
+    const originalNavigator = window.navigator;
+    const originalTop = window.top;
+
+    afterEach(function () {
+      Object.defineProperty(window, 'navigator', {
+        value: originalNavigator,
+        writable: true,
+      });
+      Object.defineProperty(window, 'top', {
+        value: originalTop,
+        writable: true,
+      });
+    });
+
     it('renders as expected when secure connection is required but not present', async () => {
       const coreStartMock = coreMock.createStart();
       httpMock.get.mockResolvedValue(createLoginState({ requiresSecureConnection: true }));
@@ -183,6 +198,94 @@ describe('LoginPage', () => {
 
       expect(wrapper.find(DisabledLoginForm)).toMatchSnapshot();
     });
+
+    it('renders CTA and cross-origin cookie warning when cookies are disabled, document is embedded inside iframe, and cross-origin cookies are blocked', async () => {
+      const coreStartMock = coreMock.createStart();
+      httpMock.get.mockResolvedValue(createLoginState());
+
+      Object.defineProperty(window, 'navigator', {
+        value: { cookieEnabled: false },
+        writable: true,
+      });
+      Object.defineProperty(window, 'top', {
+        value: {},
+        writable: true,
+      });
+
+      const wrapper = shallow(
+        <LoginPage
+          http={httpMock}
+          notifications={coreStartMock.notifications}
+          fatalErrors={coreStartMock.fatalErrors}
+          loginAssistanceMessage=""
+          sameSiteCookies="Lax"
+        />
+      );
+
+      await act(async () => {
+        await nextTick();
+        wrapper.update();
+      });
+
+      expect(wrapper.find(EuiFlexItem).children()).toMatchSnapshot();
+    });
+
+    it('renders CTA and browser settings warning when cookies are disabled, document is embedded inside iframe, and cross-origin cookies are allowed', async () => {
+      const coreStartMock = coreMock.createStart();
+      httpMock.get.mockResolvedValue(createLoginState());
+
+      Object.defineProperty(window, 'navigator', {
+        value: { cookieEnabled: false },
+        writable: true,
+      });
+      Object.defineProperty(window, 'top', {
+        value: {},
+        writable: true,
+      });
+
+      const wrapper = shallow(
+        <LoginPage
+          http={httpMock}
+          notifications={coreStartMock.notifications}
+          fatalErrors={coreStartMock.fatalErrors}
+          loginAssistanceMessage=""
+          sameSiteCookies="None"
+        />
+      );
+
+      await act(async () => {
+        await nextTick();
+        wrapper.update();
+      });
+
+      expect(wrapper.find(EuiFlexItem).children()).toMatchSnapshot();
+    });
+
+    it('renders warning when cookies are disabled and document is not embedded inside iframe', async () => {
+      const coreStartMock = coreMock.createStart();
+      httpMock.get.mockResolvedValue(createLoginState());
+
+      Object.defineProperty(window, 'navigator', {
+        value: { cookieEnabled: false },
+        writable: true,
+      });
+
+      const wrapper = shallow(
+        <LoginPage
+          http={httpMock}
+          notifications={coreStartMock.notifications}
+          fatalErrors={coreStartMock.fatalErrors}
+          loginAssistanceMessage=""
+        />
+      );
+
+      await act(async () => {
+        await nextTick();
+        wrapper.update();
+      });
+
+      expect(wrapper.find(DisabledLoginForm)).toMatchSnapshot();
+    });
   });
 
   describe('enabled form state', () => {