This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Resolve: Update npm dependencies (09-30-2021) #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and runtime electron. Updating "node-abi" might help solve this issue if it is a new release of electron Fix: "For anyone else that runs into this problem and if you're using yarn: go into yarn.lock file, find entry for node-abi, delete it, then re-run yarn." (@see electron/forge#667 (comment))
veado
approved these changes
Sep 30, 2021
veado
suggested changes
Sep 30, 2021
There was a problem hiding this comment.
Since Electron@15.x is using Node v16.5.0. (see Release Notes), update .nvmrc, Github actions + @types/node in package.json to cover 16.5.0
veado
approved these changes
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify commands:
yarn prebuildyarn generate:typesyarn build-storybookyarn storybookVerify functionality:
ETH.RUNEandBNB.RUNENot updated mentioned in #1749 +
@ledgerhq/hw-transport@ledgerhq/hw-transport-node-hid-singletonnot compatible with
@thorchain/ledger-thorchainIn case of
throw new Error('Could not detect abi for version ' + target + ' and runtime ' + runtime + '. Updating "node-abi" might help solve this issue if it is a new release of ' + runtime)Just delete
node-abifromyarn.lockand generate it again (@seeelectron/forge#667 (comment))
Closes #1800