Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Style Unlock View #270 #276

Merged
merged 9 commits into from Jul 14, 2020
Merged

Style Unlock View #270 #276

merged 9 commits into from Jul 14, 2020

Conversation

thatStrangeGuyThorchain
Copy link
Contributor

@thatStrangeGuyThorchain thatStrangeGuyThorchain commented Jul 13, 2020

  • refactored App's layout. removed fixed positions from header and footer

  • fixed mobile menu layout

  • changed paddings for page content block

  • added hiding backlinks text on mobile small devices

  • styled unlock wallet view

  • added base translations to UnlockForm

closes https://github.com/thorchain/asgardex-electron/issues/270

@veado
Copy link
Collaborator

veado commented Jul 14, 2020

Use one breakpoint for mobile screens only.

I would suggest to use the breakpoint for "very small screens" only ⬇️

Very small screens:

  • No need to remove space (margin-top??) from the row, which includes back button and headline "Unlock you wallet".
  • Could you try to size the white bacḱground to 100% (similar to large screen)?

Screenshot from 2020-07-14 06-58-51

Small screens:

  • Please use same layout (100%) as we have in large screens == remove styles for this breakpoint.

Screenshot from 2020-07-14 06-58-35

@veado
Copy link
Collaborator

veado commented Jul 14, 2020

Fix styles of "Remove" button (dark theme)

  • hover state: Change backround to grey (not white)

Screenshot from 2020-07-14 07-07-21

Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Just few change requests for styles ...

src/components/wallet/UnlockForm.style.tsx Outdated Show resolved Hide resolved
src/components/wallet/UnlockForm.style.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@veado veado merged commit 9a8d7f8 into master Jul 14, 2020
@veado veado deleted the issue-270/style-unlock-view branch July 14, 2020 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants