Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Re-structure sources used by main and renderer processes #282

Merged
merged 4 commits into from Jul 15, 2020

Conversation

veado
Copy link
Collaborator

@veado veado commented Jul 14, 2020

A lot of changes here, but 99.9% is just moving content around to have sources in a new structure:

├──  src
      ├── main      # sources of main process
      ├── renderer  # sources of renderer process
      └── shared    # shared sources

Depends on #281

Closes #275

@veado veado self-assigned this Jul 14, 2020
@veado veado force-pushed the issue-275/restructure-main-renderer branch from 89f93c1 to eaec775 Compare July 14, 2020 17:39
into issue-275/restructure-main-renderer
@veado veado marked this pull request as ready for review July 14, 2020 17:57
Copy link
Contributor

@thatStrangeGuyThorchain thatStrangeGuyThorchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a question about renaming electron -> main. if i understood correctly main is still an electron app. maybe leave a semantic name ?

small fixes at the comments.

craco.config.js Outdated Show resolved Hide resolved
tsconfig.main.json Outdated Show resolved Hide resolved
@veado
Copy link
Collaborator Author

veado commented Jul 15, 2020

have a question about renaming electron -> main. if i understood correctly main is still an electron app. maybe leave a semantic name ?

Folders main and renderer are named after Electrons Main and Renderer Processes. We have already used these naming for packaging: electron-renderer and electron-main. You will also find ipcRenderer or ipcMain in Electron (Note: xyzRenderer, xyzMain). I think it's still fine to use these names for our folders, which are all in the sense of Electron.

@thatStrangeGuyThorchain
Copy link
Contributor

Folders main and renderer are named after Electrons Main and Renderer Processes. We have already used these naming for packaging: electron-renderer and electron-main. You will also find ipcRenderer or ipcMain in Electron (Note: xyzRenderer, xyzMain). I think it's still fine to use these names for our folders, which are all in the sense of Electron.

@veado thanks for explanation

@veado veado merged commit 81dfc0f into master Jul 15, 2020
@veado veado deleted the issue-275/restructure-main-renderer branch July 15, 2020 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants