Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

THORN-2122: add a HowTo for metrics with MP Metrics and Prometheus #1120

Merged
merged 2 commits into from
Sep 27, 2018
Merged

THORN-2122: add a HowTo for metrics with MP Metrics and Prometheus #1120

merged 2 commits into from
Sep 27, 2018

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Sep 19, 2018

  • Have you followed the guidelines in our Contributing document?
  • [v2] Have you created a JIRA and used it in the commit message?
  • [v4] Have you created a GitHub Issue and used it in the commit message?
  • Have you checked to ensure there aren't other open Pull Requests for the same issue?
  • Have you built the project locally prior to submission with mvn clean install?

@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 19, 2018

CC @tradej @jclingan

@kenfinnigan
Copy link
Member

Is it worth explicitly mentioning that the metrics are exposed from the app on http://localhost:8080/metrics which is what Prometheus consumes?

@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 21, 2018

Good point @kenfinnigan!

@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 21, 2018

Fixed.

kenfinnigan
kenfinnigan previously approved these changes Sep 21, 2018
View reviewed changes
tradej
tradej suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@tradej tradej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR with changes submitted at Ladicek#2.

@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 26, 2018

I've merged @tradej's PR, so the changes are now present in this PR.

tradej
tradej previously approved these changes Sep 26, 2018
View reviewed changes
manovotn
manovotn previously approved these changes Sep 27, 2018
View reviewed changes
@Ladicek Ladicek dismissed stale reviews from manovotn and tradej via db2f65a September 27, 2018 08:19
@Ladicek
Copy link
Contributor Author

Ladicek commented Sep 27, 2018 •
edited
Loading

Rebased and resolved conflicts.

@Ladicek Ladicek merged commit 8ac04d5 into thorntail:master Sep 27, 2018
@Ladicek Ladicek deleted the howto-metrics branch September 27, 2018 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tradej tradej tradej approved these changes

@manovotn manovotn manovotn approved these changes

@kenfinnigan kenfinnigan kenfinnigan left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladicek @kenfinnigan @tradej @manovotn