Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated to German #15

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Translated to German #15

merged 2 commits into from
Feb 12, 2018

Conversation

florentinw
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Feb 12, 2018

Pull Request Test Coverage Report for Build 47

  • 37 of 37 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 93.722%

Files with Coverage Reduction New Missed Lines %
connect.js 1 95.48%
Totals Coverage Status
Change from base Build 43: -0.9%
Covered Lines: 141
Relevant Lines: 142

💛 - Coveralls

@thorpelawrence
Copy link
Owner

Would you be able to modify the tests to use the translations too?
After that, I'd be happy to merge
Thanks.

@florentinw
Copy link
Author

florentinw commented Feb 12, 2018

Changed tests to fit the new translations, but "✕ should PUT correct volume to Spotify endpoint (5004ms)" seems to be a general issue and not being caused by the new translations

@thorpelawrence
Copy link
Owner

Ah yes that test doesn't always work properly, haven't gotten around to fixing it (as you can see the test is working after restarting the build).
I will merge this tonight and then have a look at publishing it tomorrow if all goes well.

@thorpelawrence thorpelawrence changed the base branch from master to german February 12, 2018 23:34
@thorpelawrence thorpelawrence merged commit d407407 into thorpelawrence:german Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants