Add separate intent for setting the volume to a percentage #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 334
💛 - Coveralls |
|
I'll write tests for the new intent. |
visadb
force-pushed
the
master
branch
2 times, most recently
from
9767d13
to
bc8f757
Compare
|
Looks good to me! Were you able to test this manually by any chance? |
Nope, I'm new to Alexa skill development and didn't want to expend the time and energy to setup things for manual testing. And it's hopefully too simple a change to botch. 😅 |
|
No problem, I will merge it and submit to Amazon, which might take a few days for approval Thanks! |
thorpelawrence
approved these changes
Feb 26, 2021
|
Hi @visadb Amazon have accepted the changes so it should be live now, thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #80.