Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOI validation doesn't include angle brackets as permitted characters #513

Closed
rhigman opened this issue Sep 20, 2023 · 1 comment · Fixed by #607
Closed

DOI validation doesn't include angle brackets as permitted characters #513

rhigman opened this issue Sep 20, 2023 · 1 comment · Fixed by #607
Assignees
@ja573 @rhigman
Labels
bug Something isn't working

Comments

@rhigman
Copy link
Member

rhigman commented Sep 20, 2023

See #469 - the same issue occurs with the following real-world DOI:

https://doi.org/10.1002/(SICI)1098-2736(199908)36:6<637::AID-TEA4>3.0.CO;2-9

In the Thoth UI, pasting this DOI into a DOI field produces an invalid DOI warning, and deleting the angle brackets removes the warning.
@rhigman rhigman added the bug Something isn't working label Sep 20, 2023
@rhigman rhigman self-assigned this Sep 20, 2023
@rhigman rhigman mentioned this issue Sep 20, 2023
Merged
rhigman added a commit that referenced this issue Sep 21, 2023
@rhigman
Merge pull request #514 from thoth-pub/feature/513_further_doi_regex
f65bc0c 
Allow angle brackets in DOI validation (#513)
@rhigman rhigman closed this as completed Sep 21, 2023
@ja573
Copy link
Member

ja573 commented Jun 14, 2024

Getting an error now with https://doi.org/10.1002/(sici)1096-8644(1996)23+<91::aid-ajpa4>3.0.co;2-c

@ja573 ja573 reopened this Jun 14, 2024
@ja573 ja573 mentioned this issue Jun 17, 2024
Merged
@ja573 ja573 linked a pull request Jun 17, 2024 that will close this issue
Feature/513 expand doi regex #607
Merged
@ja573 ja573 self-assigned this Jun 17, 2024
@ja573 ja573 closed this as completed in 77f85a1 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ja573 ja573

@rhigman rhigman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/513 expand doi regex thoth-pub/thoth
2 participants
@ja573 @rhigman