Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit 'packaging' version #2404

Closed
wants to merge 1 commit into from

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jan 10, 2023

This fixes the following error:

$ thoth-adviser 
Traceback (most recent call last):
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/bin/thoth-adviser", line 5, in <module>
    from thoth.adviser.cli import cli
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/adviser/__init__.py", line 20, in <module>
    from .beam import Beam
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/adviser/beam.py", line 34, in <module>
    from .state import State
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/adviser/state.py", line 31, in <module>
    from thoth.python import PackageVersion
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/python/__init__.py", line 20, in <module>
    from .aiosource import AIOSource
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/python/aiosource.py", line 34, in <module>
    from .source import Source
  File "/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/thoth/python/source.py", line 34, in <module>
    from packaging.version import LegacyVersion
ImportError: cannot import name 'LegacyVersion' from 'packaging.version' (/home/max/.local/share/virtualenvs/adviser-ToNagSY3/lib/python3.8/site-packages/packaging/version.py)

Fix an import error.
@harshad16
Copy link
Member

/hold

@goern
Copy link
Member

goern commented Jan 17, 2023

ping

@VannTen
Copy link
Member Author

VannTen commented Jan 17, 2023

fixed by thoth-station/python#489
/close

@sesheta sesheta closed this Jan 17, 2023
@sesheta
Copy link
Member

sesheta commented Jan 17, 2023

@VannTen: Closed this PR.

In response to this:

fixed by thoth-station/python#489
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VannTen VannTen deleted the fix/packaging_version branch January 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants