Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .aicoe-ci.yaml #148

Merged
merged 1 commit into from
Dec 3, 2020
Merged

add .aicoe-ci.yaml #148

merged 1 commit into from
Dec 3, 2020

Conversation

bissenbay
Copy link
Contributor

Fixes: #146

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2020
@fridex
Copy link
Contributor

fridex commented Dec 1, 2020

/assign @harshad16

@bissenbay
Copy link
Contributor Author

@fridex @harshad16 PTAL

harshad16
harshad16 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 💯

@bissenbay
Copy link
Contributor Author

/assign @fridex

fridex
fridex approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bissenbay 🍻

@sesheta
Copy link
Member

sesheta commented Dec 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@sesheta sesheta merged commit 04e84e2 into thoth-station:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex approved these changes

@harshad16 harshad16 harshad16 approved these changes

@pacospace pacospace Awaiting requested review from pacospace

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@saisankargochhayat saisankargochhayat Awaiting requested review from saisankargochhayat

Assignees

@fridex fridex

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does this repo need .aicoe-ci.yaml?
4 participants
@bissenbay @fridex @sesheta @harshad16