Allow passing configuration via env vars

thoth-station · Aug 28, 2018 · 4a94d92 · 4a94d92
1 parent d150a13
commit 4a94d92
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 47 deletions.
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/thoth/common/openshift.py b/thoth/common/openshift.py
@@ -17,6 +17,7 @@
 
 """Handling OpenShift and Kubernetes objects across project."""
 
+import os
 import logging
 import requests
 
@@ -48,13 +49,15 @@ def __init__(self, *,
         config.load_incluster_config()
 
         self.ocp_client = DynamicClient(client.ApiClient(configuration=client.Configuration()))
-        self.frontend_namespace = frontend_namespace
-        self.middletier_namespace = middletier_namespace
-        self.backend_namespace = backend_namespace
-        self.infra_namespace = infra_namespace
-        self.kubernetes_api_url = kubernetes_api_url or 'https://kubernetes.default.svc.cluster.local'
-        self.kubernetes_verify_tls = kubernetes_verify_tls
-        self.openshift_api_url = openshift_api_url or 'https://openshift.default.svc.cluster.local'
+        self.frontend_namespace = frontend_namespace or os.getenv('THOTH_FRONTEND_NAMESPACE')
+        self.middletier_namespace = middletier_namespace or os.getenv('THOTH_MIDDLETIER_NAMESPACE')
+        self.backend_namespace = backend_namespace or os.getenv('THOTH_BACKEND_NAMESPACE')
+        self.infra_namespace = infra_namespace or os.getenv('THOTH_INFRA_NAMESPACE')
+        self.kubernetes_api_url = kubernetes_api_url or \
+                                  os.getenv('KUBERNETES_API_URL', 'https://kubernetes.default.svc.cluster.local')
+        self.kubernetes_verify_tls = bool(kubernetes_verify_tls or os.getenv('KUBERNETES_VERIFY_TLS', True))
+        self.openshift_api_url = openshift_api_url or \
+                                 os.getenv('OPENSHIFT_API_URL', 'https://openshift.default.svc.cluster.local')
         self._token = token
 
     @property