Add Sentry support #108
Merged
Add Sentry support #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/L
|
I was not able to update lock (some local issues), let's use Kebechet for that. |
|
Build succeeded.
|
sesheta
added
the
size/L
fridex
force-pushed
the
sentry-logging
branch
from
0096ac7
to
d78bd09
Compare
sesheta
added
the
size/L
goern
reviewed
Sep 25, 2018
| @@ -85,9 +88,16 @@ def init_logging(logging_configuration: dict = None) -> None: | |||
|
|
|||
| _init_log_levels(logging_configuration) | |||
|
|
|||
| if _SENTRY_DSN: | |||
There was a problem hiding this comment.
any docs on this? what and why to do?
goern
reviewed
Sep 25, 2018
Pipfile
Outdated
| @@ -7,6 +7,7 @@ name = "pypi" | |||
| "rfc5424-logging-handler" = "*" | |||
| daiquiri = "*" | |||
| requests = "*" | |||
| raven = "*" | |||
There was a problem hiding this comment.
why raven? it reads like "Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python https://sentry.io"
There was a problem hiding this comment.
Ah, they are fast. That is the way I did it in the previous project :)
fridex
force-pushed
the
sentry-logging
branch
from
d78bd09
to
503de97
Compare
sesheta
added
the
size/L
fridex
force-pushed
the
sentry-logging
branch
from
503de97
to
005960e
Compare
sesheta
added
the
size/L
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: thoth-station/core#150