Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] An option to configure different managers per overlay #1126

Closed
2 tasks
Tracked by #401
codificat opened this issue Aug 31, 2022 · 3 comments · Fixed by #1156
Closed
2 tasks
Tracked by #401

[5pt] An option to configure different managers per overlay #1126

codificat opened this issue Aug 31, 2022 · 3 comments · Fixed by #1156
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@codificat
Copy link
Member

codificat commented Aug 31, 2022

Problem statement

A .thoth.yaml configuration file supports overlays, which allows e.g. different configurations for thoth adviser (different runtimes, different recommendation types). However, the managers configuration section is common to all the overlays.

I would like to be able to have different Kebechet manager configurations in different overlays, so I can choose to e.g. get the benefits of thoth advice in one overlay but just use the pipenv-based update manager for another.

The fact that there is a single manager configuration for the whole repo means that enabling a certain manager is an "all or nothing" configuration option. If I have 10 overlays and 1 of them can not work with thoth-advise manager, then I can not use thoth-advise in the other 9 overlays either.

High-level Goals

To be able to configure different managers / options per overlay.

Proposal description

Some options to implement this:

  1. If .thoth.yaml has an overlays_dir configured, then the managers configuration section contains one entry per overlay. This approach would be consistent with how thoth / thamos configuration looks like, but it might introduce too much redundancy
  2. Allow individual overlays to override the global configuration, by having the same configuration structure as now but adding the possibility to introduce overlay-specific overrides
  3. Add allow and disallow to each manager's configuration options, where the user can specify which repos each manager is (dis)allowed to act on.

Alternatives

Keep it as is. It works, but it is less flexible.

Additional context

Acceptance Criteria

  • the .thoth.yaml configuration file has some way to specify different manager configurations for different overlays
  • it is possible to enable and disable different managers in different overlays
@codificat codificat added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 31, 2022
@codificat
Copy link
Member Author

/sig user-experience

@sesheta sesheta added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label Aug 31, 2022
@KPostOffice KPostOffice added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 14, 2022
@Gkrumbach07
Copy link
Member

Suggested Config

  • allow and disallow setting to each manager

@Gkrumbach07 Gkrumbach07 changed the title An option to configure different managers per overlay [2pt] An option to configure different managers per overlay Sep 20, 2022
@Gkrumbach07 Gkrumbach07 changed the title [2pt] An option to configure different managers per overlay [3pt] An option to configure different managers per overlay Sep 20, 2022
@Gkrumbach07 Gkrumbach07 changed the title [3pt] An option to configure different managers per overlay [5pt] An option to configure different managers per overlay Sep 20, 2022
@codificat
Copy link
Member Author

/wg cnbi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants