Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2pt] pipfile_requirements manager fails with editable installs #1142

Closed
codificat opened this issue Sep 20, 2022 · 1 comment · Fixed by #1175
Closed

[2pt] pipfile_requirements manager fails with editable installs #1142

codificat opened this issue Sep 20, 2022 · 1 comment · Fixed by #1175
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@codificat
Copy link
Member

Bug description

When there is an entry with an editable path in the Pipfile, like:

src = {editable = true, path = "./"}

the pipfile_requirements manager fails to identify the version of the package, reports this as a problem by creating an issue, and does not complete the generation of requirements.txt

Related: #1125 is about the update manager handling local paths.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Have a Pipfile with a local editable path in an entry
  2. Have the pipfile_requirements manager enabled
  3. Run kebechet

Actual behavior

An example of an issue generated from such a configuration: shreekarSS/aicoe-osc-demo#2

Expected behavior

Kebechet's pipfile_requirements is expected to know how to translate a Pipfile to an equivalent requirements.txt, and this would include these type of entries.

Environment information

Kebechet v1.10.5

Additional context

os-climate/aicoe-osc-demo#207

@codificat codificat added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2022
@codificat
Copy link
Member Author

/sig user-experience
/priority important-longterm

@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 20, 2022
@Gkrumbach07 Gkrumbach07 changed the title pipfile_requirements manager fails with editable installs [2pt] pipfile_requirements manager fails with editable installs Sep 20, 2022
@Gkrumbach07 Gkrumbach07 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants