Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry.lock [package.dependencies] conflict on markers #192

Closed
abompard opened this issue Sep 22, 2021 · 3 comments
Closed

poetry.lock [package.dependencies] conflict on markers #192

abompard opened this issue Sep 22, 2021 · 3 comments
Assignees
Labels
human_intervention_required kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@abompard
Copy link
Contributor

This is a followup of #186. I have a use case on my poetry-based project where the package arrow depends on package typing-extensions with markers python_version < "3.8", and package bravado depends on package typing-extensions too but without markers.
When I'm running on python 3.9, poetry installs typing-extensions, but micropipenv does not:

Ignoring typing-extensions: markers 'python_version < "3.8"' don't match your environment

As a result, bravado is missing one of its dependencies and pkg_resources reports an error:

pkg_resources.DistributionNotFound: The 'typing-extensions' distribution was not found and is required by bravado

I'm attaching my pyproject.toml.txt file and my poetry.lock.txt file (as text, because Github filters extensions).

@goern
Copy link
Member

goern commented Oct 4, 2021

/kind bug
/priority important-soon
/assign @fridex
/triage accepted

@sesheta sesheta added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 4, 2021
frenzymadness added a commit to frenzymadness/micropipenv that referenced this issue Oct 4, 2021
@frenzymadness frenzymadness mentioned this issue Oct 4, 2021
2 tasks
@frenzymadness
Copy link
Collaborator

There is a PR to address this issue. It'd be awesome if you could test it. Also, if you have more projects you can test micropipenv on, do it please and provide any other problems you find. It's very helpful.

@abompard
Copy link
Contributor Author

abompard commented Oct 4, 2021

Yep, the PR worked on my test project. Thanks!

@sesheta sesheta closed this as completed in 97f3894 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
human_intervention_required kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants