Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry fixes #296

Merged
merged 5 commits into from
May 16, 2024
Merged

Poetry fixes #296

merged 5 commits into from
May 16, 2024

Conversation

abompard
Copy link
Contributor

Two fixes for Poetry compatibility.

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

  • support subfolders for git sources
  • use the resolved reference (commit hash) that poetry has set in the lockfile rather than the specified reference (symbolic ref such as tag or branch) which can differ from poetry's lockfile

@abompard
Poetry: handle subdirectories in git sources
7fc5c12 
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard
Poetry: in VCS sources, use resolved_reference if available
466dbb0 
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard
Copy link
Contributor Author

I do not think the error in CI is related to this PR

@frenzymadness
Copy link
Collaborator

Thank you. The code looks good to me. I've pushed a commit that should fix the CI.

frenzymadness
frenzymadness approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. @abompard wanna take a look at my changes before I merge this?

@abompard
Copy link
Contributor Author

Thanks for fixing it up, lgtm :-)

@frenzymadness frenzymadness merged commit bfb04b2 into thoth-station:master May 16, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzymadness frenzymadness frenzymadness approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@harshad16 harshad16 Awaiting requested review from harshad16 harshad16 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abompard @frenzymadness