Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop releasing prescriptions as a container image #17210

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 14, 2021

What type of PR is this?

Related: #50

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2021
@fridex
Copy link
Contributor Author

fridex commented Sep 20, 2021

/assign @harshad16

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks , just one comment

.aicoe-ci.yaml Outdated Show resolved Hide resolved
@harshad16
Copy link
Member

@fridex can you please rebase
i will review once again and merge it

@fridex
Copy link
Contributor Author

fridex commented Sep 23, 2021

@fridex can you please rebase
i will review once again and merge it

Thanks, rebased now. 👍🏻

@harshad16
Copy link
Member

@fridex rebase removed the change i had suggested
can you make the .aicoe-ci.yaml as

check: []

@fridex
Copy link
Contributor Author

fridex commented Sep 23, 2021

Ah, sorry about that. Now pushed again with the change. PTAL

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@sesheta sesheta merged commit 76571e5 into thoth-station:master Sep 23, 2021
@fridex fridex deleted the rm-prescriptions-container branch September 23, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants