Feature: async source #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Görn <goern@redhat.com>
Signed-off-by: Christoph Görn <goern@redhat.com>
sesheta
added
the
size/XL
sefkhet-abwy
bot
added
the
do-not-merge/work-in-progress
|
Build succeeded.
|
Signed-off-by: Christoph Görn <goern@redhat.com>
|
Build succeeded.
|
sefkhet-abwy
bot
removed
the
do-not-merge/work-in-progress
fridex
reviewed
Nov 5, 2019
thoth/python/aiosource.py
Outdated
| # https://www.python.org/dev/peps/pep-0503/ | ||
| link_text = link_text[:-1] | ||
|
|
||
| if self.is_normalized_python_package_name(package_name) and package_name == link_text: |
There was a problem hiding this comment.
link_text should be normalized, see #161
There was a problem hiding this comment.
Any reason why not always operate on normalized package names?
Signed-off-by: Christoph Görn <goern@redhat.com>
|
Build succeeded.
|
Signed-off-by: Christoph Görn <goern@redhat.com>
sesheta
added
the
approved
|
Build succeeded.
|
|
regate |
|
Build succeeded (gate pipeline).
|
ghost
merged commit
This was referenced Nov 8, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.