Add PLZ_ARGS variable to pleasew #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
reviewed
Sep 29, 2020
pleasew
Outdated
| @@ -69,4 +69,4 @@ for x in `ls "$DIR"`; do | |||
| done | |||
| ln -sf "${DIR}/please" "${LOCATION}/plz" | |||
| echo -e >&2 "${GREEN}Should be good to go now, running plz...${RESET}" | |||
| exec "$TARGET" "$@" | |||
| exec "$TARGET" "$PLZ_ARGS" "$@" | |||
There was a problem hiding this comment.
This is an error if it's undefined? (we set +u at the top of the script)
I think something like "${PLZ_ARGS+}" would help, but we also need to be sure it doesn't inject a spurious empty string into the arguments. Maybe just ${PLZ_ARGS+} would do it?
There was a problem hiding this comment.
Silly me, I haven't actually tried it without $PLZ_ARGS 😄
There was a problem hiding this comment.
I think ${PLZ_ARGS:-} will be the right syntax here.
sagikazarmark
force-pushed
the
plz-args
branch
3 times, most recently
from
287d42e
to
96b28c8
Compare
|
The breaking CI does not seem to be related. |
I think you might just need to merge master in. I fixed the up to date failures yesterday. |
|
I rebased from master this morning. |
sagikazarmark
force-pushed
the
plz-args
branch
from
96b28c8
to
51a590f
Compare
sagikazarmark
force-pushed
the
plz-args
branch
from
51a590f
to
8581109
Compare
Tatskaari
force-pushed
the
master
branch
2 times, most recently
from
5e24a0d
to
e5a2b6d
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
plz-args
branch
from
8581109
to
3dff715
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Tatskaari
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running please in a CI environment, copying the same arguments between scripts is error prone and tedious.
Setting a global
PLZ_ARGSenvironment variable that's automatically in every invocation is a nice way around that. For example, setting plain output for every CI step is a good practice.I realized this might not be the absolute best solution, but it's a start and can be the start of a discussion.