Fix list concat overwriting #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddenrich
approved these changes
May 16, 2024
samwestmoreland
approved these changes
May 17, 2024
HartBlanc
reviewed
May 17, 2024
| @@ -363,7 +364,7 @@ func (l pyList) Operator(operator Operator, operand pyObject) pyObject { | |||
| } | |||
| panic("Cannot add list and " + operand.Type()) | |||
| } | |||
| return append(l, l2...) | |||
| return slices.Clip(append(l, l2...)) | |||
There was a problem hiding this comment.
Do we need to apply this change to the pyFrozenList case a few lines above too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166
Looks like this is due to the slices overwriting since on append they both think they have extra capacity, but are in fact sharing it. A pure Go example: https://go.dev/play/p/pLl6MlMr3V4
This fixes this particular case; I don't think there are others at present, we seem to construct lists with capacity equal to their final size in other instances.