Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JSONDecodable to Decodable #107

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Rename JSONDecodable to Decodable #107

merged 1 commit into from
Apr 17, 2015

Conversation

gfontenot
Copy link
Collaborator

Decodable objects are able to be decoded, returning a
Decoded<DecodedType>. This is a nice synergy, and leaves us open to
other non-JSON operations in the future.

@tonyd256
Copy link
Contributor

I like the change in general because I think it would be nice to get away from JSON references in general. This is getting us one step closer. Using Value instead of JSON would be the final nail in the coffin.

I'm a 👍 for this!

@gfontenot
Copy link
Collaborator Author

I think right now, JSON is at least conceptually tied to parsing JSON. If an example comes up where we (or someone else) has, for example, a YAML parser that works with the JSON type without modification, I think it would make sense to change it at that point. And we could always typealias JSON = Value if it comes to that to maintain backwards compatibility.

@gfontenot
Copy link
Collaborator Author

ping @thoughtbot/ios and @hyperspacemark for feedback please

@dazmuda
Copy link

dazmuda commented Apr 16, 2015

👍 I really like this change. You decode Decodable objects. Even when parsing JSON, the nomenclature decodeing JSONDecodable objects is a bit awkward.

@hyperspacemark
Copy link

I dig it. 👍

@jnutting
Copy link
Contributor

I am all in favor of this :shipit:

`Decodable` objects are able to be `decode`d, returning a
`Decoded<DecodedType>`. This is a nice synergy, and leaves us open to
other non-JSON operations in the future.
@gfontenot gfontenot merged commit 3a0d057 into master Apr 17, 2015
@gfontenot gfontenot deleted the gf-decoded branch April 17, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants