Generalize the type for sequence taking a dict
#341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is a non-breaking change 🎉 |
|
👍 love it |
There wasn't actually any real reason to limit this to working on `[String: Decoded<T>]` values. Instead, we should be able to use this function with any key type.
gfontenot
force-pushed
the
gf-generalize-sequence
branch
from
5e9cfa8
to
6b5c06e
Compare
| @@ -42,8 +42,8 @@ public func sequence<T>(xs: [Decoded<T>]) -> Decoded<[T]> { | |||
| - returns: A `Decoded` `Dictionary` of unwrapped `T` values assigned to their | |||
| original keys | |||
| */ | |||
| public func sequence<T>(xs: [String: Decoded<T>]) -> Decoded<[String: T]> { | |||
| var accum = Dictionary<String, T>(minimumCapacity: xs.count) | |||
| public func sequence<Key, Value>(xs: [Key: Decoded<Value>]) -> Decoded<[Key: Value]> { | |||
There was a problem hiding this comment.
Variable Name Violation: Variable name should be between 3 and 40 characters long: 'xs' (variable_name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There wasn't actually any real reason to limit this to working on
[String: Decoded<T>]values. Instead, we should be able to use thisfunction with any key type.
Another change that came about because of having trouble writing documentation.
Fun stuff.