Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siri intent definition localisation #214

Merged
merged 10 commits into from Dec 28, 2018
Merged

Siri intent definition localisation #214

merged 10 commits into from Dec 28, 2018

Conversation

sharplet
Copy link
Contributor

When I submitted an initial beta build to TestFlight, I got a warning about missing localisations for our supported languages (Italian, French and Polish). This work-in-progress PR first configures the project for Base Internationalisation, then sets up strings files for our various languages. This branch can then become a staging area for the actual translations, which I'll be reaching out to previous contributors for help with.

"Check the weather",
comment: "Siri suggestion phrase to check weather")
private static let checkWeatherSuggestedPhrase = NSString
.deferredLocalizedIntentsString(with: "CheckWeatherSuggestedPhrase") as String
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new concept of deferred localisation enables a donated intent to be localised potentially much later, when the device could have changed language.

@@ -39,6 +39,10 @@
</dict>
<key>NSPhotoLibraryUsageDescription</key>
<string>Tropos does not access your photo library.</string>
<key>NSUserActivityTypes</key>
<array>
<string>CheckWeatherIntent</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automatically added by Xcode.

@@ -0,0 +1,6 @@
"8SKsHj" = "Check weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Italian.


"Hpkcrr" = "${conditionsDescription}";

"RwwC7B" = "Check the current weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Italian.

@@ -0,0 +1,6 @@
"8SKsHj" = "Check weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Polish.


"Hpkcrr" = "${conditionsDescription}";

"RwwC7B" = "Check the current weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Polish.

@@ -0,0 +1,6 @@
"8SKsHj" = "Check weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Swedish.


"Hpkcrr" = "${conditionsDescription}";

"RwwC7B" = "Check the current weather forecast";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation into Swedish.

@sharplet
Copy link
Contributor Author

Hello former Tropos contributors! Would you be interested in contributing translations for Tropos’ new custom Siri shortcut?

If you're able to help out, thanks! The new strings are located at Sources/TroposIntents/*.lproj/Intents.strings. Please open a new pull request against this branch, intent-localisation.

@sharplet
Copy link
Contributor Author

For anyone contributing translations, could you also take a look at CheckWeatherSuggestedPhrase in Sources/Tropos/Resources/*.lproj/Localizable.strings? This phrase should be a short example phrase that a user might want to say to Siri to check the weather using Tropos, not necessarily a direct translation of "check the weather" if there's something else more idiomatic.

@sharplet
Copy link
Contributor Author

This is probably terrible, but for now I've added Polish and Swedish via Google Translate, in order to try and get something shipped for the iOS 12 launch. I'll be travelling for a few weeks, but I'll try and get these translations checked/improved once I return.

@sharplet sharplet changed the title WIP: Siri intent definition localisation Siri intent definition localisation Sep 15, 2018
@sharnik
Copy link

sharnik commented Sep 16, 2018

This is probably terrible, but for now I've added Polish

I've checked and the Polish translations look good. 👍

@sharplet
Copy link
Contributor Author

@sharnik Thank you!

@sharplet sharplet force-pushed the intent-localisation branch 4 times, most recently from fa72d91 to bdd4ff9 Compare September 26, 2018 01:45
@sharplet
Copy link
Contributor Author

There's something up with the simulators on Circle CI right now. The tests are passing on my machine, but I don't currently have the GM installed, so I'll have to wait before I can verify using the GM (unless someone else wants to have a go).

@sharplet sharplet merged commit 1a1be83 into master Dec 28, 2018
@sharplet sharplet deleted the intent-localisation branch December 28, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants